Issue 2279 extra #2320
Merged
Issue 2279 extra #2320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change unifies "filter" label handling for tree/table mode in the file search, we show now that the matches are filtered in both cases. See eclipse-platform#2279
If the search view has matches for 100.000 files, it would hang forever on updating the view via F5 because it asks getMatchCount() for every element and that traverses entire result again and again. This change remembers last computed result and returns that value if there were no further changes on the search result itself. See eclipse-platform#2279
iloveeclipse
force-pushed
the
issue_2279_extra
branch
from
a8e99b2
to
ef3d2bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change unifies "filter" label handling for tree/table mode in the
file search, we show now that the matches are filtered in both cases.
Example:
If the search view has matches for 100.000 files (like above), it would hang forever on updating the view via F5 because it asks getMatchCount() for every element and that traverses entire result again and again.
This change remembers last computed result and returns that value if there were no further changes on the search result itself. This avoids UI hang completely.
See #2279